Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/clean up repo #160

Merged
merged 23 commits into from
Jul 18, 2024
Merged

Feat/clean up repo #160

merged 23 commits into from
Jul 18, 2024

Conversation

cardosofede
Copy link
Contributor

Changes:

  • added isort, black, flake and pre-commit
  • format all the files
  • remove unused modules
  • remove quants lab

cardosofede added 23 commits July 16, 2024 17:54
@cardosofede
(feat) add pre-commit file
8981974
@cardosofede
(feat) update styling dependencies
be148eb
@cardosofede
(feat) remove quants lab
dec22c7
@cardosofede
(feat) update pyproject.toml
ff35581
@cardosofede
(feat) add more config to pyproject
e8071a1
@cardosofede
(feat) update pyproject
f4fcf54
@cardosofede
(feat) improve pyproject
75908d6
@cardosofede
(feat) update precommit
1f686e9
@cardosofede
(feat) update precommit
a87e45e
@cardosofede
(feat) improve formatting
37f63e1
@cardosofede
(feat) final version of pyproject
033853d
@cardosofede
(feat) remove unused components
ae8142c
@cardosofede
(feat) update base components
f163c58
@cardosofede
(feat) update controllers configs components
785eab1
@cardosofede
(feat) update distribution inputs
7a87588
@cardosofede
(feat) formatting controllers
e7eba7e
@cardosofede
(feat) format visualizations
f123570
@cardosofede
(feat) update st utils
81b47f4
@cardosofede
(feat) update config pages
2637949
@cardosofede
(feat) update main page
ffd1799
@cardosofede
(feat) update backend style
cd8c1bb
@cardosofede
(feat) update glom import
759c286
@cardosofede
(feat) general precommit run
9967322
@rapcmia rapcmia requested review from rapcmia and nikspz July 17, 2024 02:32
@rapcmia
Copy link
Contributor

rapcmia commented Jul 17, 2024

PR update:

  • Backend and dashboard source + broker compose file, no go and created bug ticket 25
  • Dashboard source + backend and broker compose file ok used on testing this PR
    image

Added isort, black, flake8 and pre-commit

  • Remove and recreate env for dashboard ok
  • Not sure how we can check black ?
    image

initial tests:

  • Test bot orchestration
    • Accounts with credentials (CRUD) and portfolio ok
    • Instances and random config-generator ok
    • Ran test with random config-generator and switch to diff config ok

Todo:

  • Run tests on all config-generator
  • Run backtests on pmm controllers
  • Deploy and observe instance

@nikspz
Copy link
Contributor

nikspz commented Jul 17, 2024

Test perfromed:

  • Clone dashboardPR160 + backendPR24
  • Removed dashboard and backend-api environment
  • set up env for dashboardPR160 + backendPR24 again
  • start dashboard and backend-api
  • Run backtesting successfully on PMM simple, PMM Dynamic, D-man maker v2, Bollinger bands, MACD_BB

Pending:
Instance test with hummingbot/hummingbot#7121

@rapcmia rapcmia mentioned this pull request Jul 18, 2024
Merged
rapcmia
rapcmia approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@rapcmia rapcmia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Setup this PR with backend PR24, broker from deploy docker compose and deploy successfully hummingbot [PR7121](https://github.com/hummingbot/hummingbot/pull/7121) image
  • Added account and credentials
    • Create, update and remove random connectors
    • Check portfolio matched on exchange current assets
  • Ran backtests few backtesting using kucoin and binance on PMM_simple and PMM_dynamic
  • Ran random configs and switched to other controllers to check possible mixed setup, all ok
  • Ran random configs and deploy using kucoin and binance_perpetual as connector ok

@nikspz nikspz merged commit 7f0df00 into development Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikspz nikspz nikspz approved these changes

@rapcmia rapcmia rapcmia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cardosofede @rapcmia @nikspz